fix(dashboard): show eval suite labels#1397
Merged
Merged
Conversation
christso
commented
Jun 17, 2026
christso
left a comment
christso
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed PR #1397 against origin/main at 2aa062c.
No blocking findings.
Checked:
- Suite label visibility is gated by shouldShowSuiteLabels, suppresses single-suite runs, and shows mixed or partial suite metadata without rendering empty Uncategorized chips.
- Path-like suite formatting compacts labels while preserving the full raw value in the title.
- All Evals and eval-detail sidebar links preserve project-scoped and non-project route params.
- Screenshot evidence exists in the private evidence branch and covers red run table, green run table, and green eval sidebar states.
Verification:
- bun test apps/dashboard/src/lib/run-detail-context.test.ts passed: 8 tests.
- Initial Dashboard build failed because this worktree did not have dependencies installed: tsc: command not found. After bun install --frozen-lockfile, cd apps/dashboard && bun run build passed.
- GitHub CI check rollup is green.
Residual risk: there is no automated render/layout test for very long suite labels or narrow/mobile sidebar widths; current UX evidence is desktop screenshot coverage only.
Collaborator
Author
|
Follow-up verification after installing dependencies in the review worktree:
The earlier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bunx biome check apps/dashboard/src/components/EvalSuiteLabel.tsx apps/dashboard/src/components/RunDetail.tsx apps/dashboard/src/components/Sidebar.tsx apps/dashboard/src/lib/run-detail-context.ts apps/dashboard/src/lib/run-detail-context.test.tsbun test apps/dashboard/src/lib/run-detail-context.test.tscd apps/dashboard && bun run buildbun run buildbiome check .Manual UAT
origin/main: same mixed-suite fixture showed All Evals test IDs without suite labels. Screenshot:/tmp/agentv-suite-labels-red-run-table.pnggithub-actions/security-reviewsuite chips. Screenshot:/tmp/agentv-suite-labels-run-table.png/tmp/agentv-suite-labels-eval-sidebar.pngFixture used for UAT:
/tmp/agentv-suite-labels-workspace/.agentv/results/runs/github-actions::2026-06-17T05-55-30-000Z/index.jsonl.Bead:
av-2s7.13